D27292: set the share comment as UDS_COMMENT for the UI to display
This revision was automatically updated to reflect the committed changes. Closed by commit R320:dddafae55363: smb: set the share comment as UDS_COMMENT for the UI to display (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27292?vs=75384&id=75602 REVISION DETAIL https://phabricator.kde.org/D27292 AFFECTED FILES smb/kio_smb_browse.cpp To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27292: set the share comment as UDS_COMMENT for the UI to display
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug105086 REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27292: set the share comment as UDS_COMMENT for the UI to display
sitter added a comment. We talked about this on telegram and what Kai is thinking of may be the mime comment. Upon review UDS_COMMENT (or KFileItem::comment()) seems to simply not be modeled in dolphin. The model has a Comment column but as far as I can tell the data for that column is never set, which explains why dolphin doesn't show the comment even when enabling the relevant column in the details view. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27292: set the share comment as UDS_COMMENT for the UI to display
broulik added a comment. The comment will be shown in the status bar when hovering a file. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27292: set the share comment as UDS_COMMENT for the UI to display
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY currently this seems to not really have any visibility through dolphin so concluding the fix also requires changes to dolphin to enable the comment somewhere. it is technically a column in the details view but that doesn't actually seem to work CCBUG: 105086 TEST PLAN hoping for the best in absence of a UI! REPOSITORY R320 KIO Extras BRANCH bug105086 REVISION DETAIL https://phabricator.kde.org/D27292 AFFECTED FILES smb/kio_smb_browse.cpp To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
