D27293: smb: do not map uid and gid

2020-02-13 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:25a02064dbee: smb: do not map uid and gid (authored by 
sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27293?vs=75385=75601

REVISION DETAIL
  https://phabricator.kde.org/D27293

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


D27293: smb: do not map uid and gid

2020-02-11 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug212801

REVISION DETAIL
  https://phabricator.kde.org/D27293

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


D27293: smb: do not map uid and gid

2020-02-10 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  libsmbc returns the uid/gid of the process, not of the file, the data
  is entirely useless to us. do not list it.
  currently there is no way to get the actual uid/gid of a dirent. internally
  there seems to be tech available that uses the samba unix extension but
  that doesn't have any public API.
  
  in short: we can't determine ownership client-side
  
  BUG: 212801

TEST PLAN
  no longer shows current user as owner. in particular when that is not true!

REPOSITORY
  R320 KIO Extras

BRANCH
  bug212801

REVISION DETAIL
  https://phabricator.kde.org/D27293

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov