D27294: fix free space calculation
This revision was automatically updated to reflect the committed changes. Closed by commit R320:6832817f311b: smb: fix free space calculation (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27294?vs=75386&id=75600 REVISION DETAIL https://phabricator.kde.org/D27294 AFFECTED FILES smb/kio_smb_browse.cpp To: sitter, ngraham, meven Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27294: fix free space calculation
ngraham accepted this revision. ngraham added a comment. Nice! REPOSITORY R320 KIO Extras BRANCH bug298801 REVISION DETAIL https://phabricator.kde.org/D27294 To: sitter, ngraham, meven Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27294: fix free space calculation
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Tested with success with samba 4.5 I gave a try to fix this issue, did not got through until samba's code. Thanks REPOSITORY R320 KIO Extras BRANCH bug298801 REVISION DETAIL https://phabricator.kde.org/D27294 To: sitter, ngraham, meven Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D27294: fix free space calculation
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - collapse statvfs call, there's no purpose in manually opening the file when libsmbc has a convenience wrapper that does exactly what we need with less code on our end - blockSize is now calculated as per the conditional branches in smbc_stat.c - free space calculation is now backwards compatible with slightly busted legacy versions of libsmbc not setting f_bavail FIXED-IN: 19.12.3 BUG: 298801 TEST PLAN free space calculation now works with windows10, ubuntu18.04, ubuntu19.10 REPOSITORY R320 KIO Extras BRANCH bug298801 REVISION DETAIL https://phabricator.kde.org/D27294 AFFECTED FILES smb/kio_smb_browse.cpp To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
