D27352: retain atime properly

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this was broken since forever I guess. when the .part resume tech was
  added it didn't correctly retain the access time. it was trying to
  get the atime of 'file', but 'file' when resuming refers to the .part which
  was deleted prior to the mtime adjustment so the QFileInfo(file).lastRead
  would produce an Invalid QDateTime which then results in us setting random
  nonesense as access time on the file.
  instead simply use dstFile. it is the path of the actual final destination
  file of which the atime is **actually** the one we want to preserve here
  considering we've literally just accessed that file by copying it ^^
  
  BUG: 410624
  FIXED-IN: 19.12.3

TEST PLAN
  copy file form smb to local has sound atime

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Méven Car]

meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Nathaniel Graham]

ngraham added a comment.


  So when I copy a file from my samba share to my desktop, the accessed time of 
the copied file on my machine should match the accessed time of the version on 
the server? If so, it doesn't seem to work for me; the accessed time is reset 
to the time when the file was copied.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Harald Sitter]

sitter added a comment.


  No, the access time is always the current time, the modified time should not 
change.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Nathaniel Graham]

ngraham added a comment.


  The modified time changes too. Am I testing this right?
  
  F8100051: vokoscreenNG-2020-02-12_11-52-33.mp4 


REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Harald Sitter]

sitter added a comment.


  I think I tried with moving. Currently not at home to check.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Harald Sitter]

sitter added a comment.


  Oh I'm sorry, I thought this was the other time diff.
  
  In this case before the accessed time before the patch was flat out garbage 
https://bugsfiles.kde.org/attachment.cgi?id=121948 note the year **2106**

REPOSITORY
  R320 KIO Extras

BRANCH
  bug410624

REVISION DETAIL
  https://phabricator.kde.org/D27352

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27352: retain atime properly

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:7f47119b22d5: smb: retain atime properly (authored by 
sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27352?vs=75558&id=75597

REVISION DETAIL
  https://phabricator.kde.org/D27352

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov