D27366: Construct NullEngine with KPluginMetaData()

2020-02-13 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1dc36bc2cee4: Construct NullEngine with KPluginMetaData() 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27366?vs=75604&id=75613

REVISION DETAIL
  https://phabricator.kde.org/D27366

AFFECTED FILES
  src/plasma/private/dataenginemanager.cpp

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27366: Construct NullEngine with KPluginMetaData()

2020-02-13 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27366

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27366: Construct NullEngine with KPluginMetaData()

2020-02-13 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The deprecated constructor taking a `KPluginInfo` unconditionally calls 
`toMetaData()` and then asserts.
  
  BUG: 417557

TEST PLAN
  - Compiles. Can't actually reproduce the crash, even when I delete my 
geolocation dataengine

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27366

AFFECTED FILES
  src/plasma/private/dataenginemanager.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns