D27396: support icon.width/height

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> TabButton.qml:61
>  opacity: enabled || control.highlighted || control.checked ? 1 : 
> 0.4
> -color: control.activeFocus && !control.down ? 
> theme.highlightedTextColor : theme.buttonTextColor
>  horizontalAlignment: Text.AlignHCenter

@mart Why did you remove the color here? Seems unrelated to size?
This broke things e.g. with  Breeze Dark (as can be seen e.g. with the weather 
widget's tab buttons (use BBC service to have tabs).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma, broulik
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D27396: support icon.width/height

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in TabButton.qml:61
> @mart Why did you remove the color here? Seems unrelated to size?
> This broke things e.g. with  Breeze Dark (as can be seen e.g. with the 
> weather widget's tab buttons (use BBC service to have tabs).

Created a merge request to restore this, as I could not find a reason:
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/15

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma, broulik
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D27396: support icon.width/height

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support the icon size hint of the control. Reinstate it in ToolButton
  and add the support for the other controls
  CCBUG:417514

TEST PLAN
  possible to control buttons icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27396: support icon.width/height

[Kai Uwe Broulik]

broulik added a comment.


  Don't we want to set a default? I keep seeing people hardcoding `icon.width` 
all over the place when they used PC3 and I want that to stop

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart added a comment.


  In D27396#611425 , @broulik wrote:
  
  > Don't we want to set a default? I keep seeing people hardcoding 
`icon.width` all over the place when they used PC3 and I want that to stop
  
  
  then should be i think smallMedium size for toolbuttons (and i guess 
tabbuttons) and small for normal pushbuttons

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart updated this revision to Diff 75675.
mart added a comment.


  - default icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75672&id=75675

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart updated this revision to Diff 75677.
mart added a comment.


  - don't expose externally default size

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75675&id=75677

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3de1c2462eda: support icon.width/height (authored by 
mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75677&id=75678

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns