D27399: make sure the size hints are integer and even
mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY for retrocompatibility with pc2 units.gridUnit * 1.6 is used a lot as size hint (we have to guarantee buttons and textfields have the same height by default for perfect horizontal alignment. tough we have make sure that size is integer and even otherwise we'll have a lot of internal misalignments REPOSITORY R242 Plasma Framework (Library) BRANCH phab/sizefixes REVISION DETAIL https://phabricator.kde.org/D27399 AFFECTED FILES src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/TabButton.qml src/declarativeimports/plasmacomponents3/TextField.qml src/declarativeimports/plasmacomponents3/ToolButton.qml To: mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27399: make sure the size hints are integer and even
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/sizefixes REVISION DETAIL https://phabricator.kde.org/D27399 To: mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27399: make sure the size hints are integer and even
This revision was automatically updated to reflect the committed changes. Closed by commit R242:667dce502acf: make sure the size hints are integer and even (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27399?vs=75681&id=75688 REVISION DETAIL https://phabricator.kde.org/D27399 AFFECTED FILES src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/TabButton.qml src/declarativeimports/plasmacomponents3/TextField.qml src/declarativeimports/plasmacomponents3/ToolButton.qml To: mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27399: make sure the size hints are integer and even
davidedmundson added a comment. Please ensure that you've run the relevant plasma-framework/tests/components in qmlscene REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27399 To: mart, broulik Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns