D27535: Add XdgOutputV1 version 2

2020-03-24 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8b355825a3b8: Add XdgOutputV1 version 2 (authored by 
davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27535?vs=76077&id=78345

REVISION DETAIL
  https://phabricator.kde.org/D27535

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/registry.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin, zzag
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27535: Add XdgOutputV1 version 2

2020-02-21 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in xdgoutput_interface.cpp:319
> noob question: what would happen if you didn't have this check?

If a client that only knew version1 connected and we sent this event, the 
client would raise a protocol error and quit.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin, zzag
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27535: Add XdgOutputV1 version 2

2020-02-21 Thread Vlad Zahorodnii 
zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin, zzag
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27535: Add XdgOutputV1 version 2

2020-02-20 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 LGTM

INLINE COMMENTS

> xdgoutput_interface.cpp:319
> +}
> +if (wl_resource_get_version(d->resource) < 
> ZXDG_OUTPUT_V1_DESCRIPTION_SINCE_VERSION) {
> +return;

noob question: what would happen if you didn't have this check?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27535: Add XdgOutputV1 version 2

2020-02-20 Thread David Edmundson 
davidedmundson updated this revision to Diff 76077.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27535?vs=76076&id=76077

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/registry.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27535: Add XdgOutputV1 version 2

2020-02-20 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Will be useful for making plasma widgets not move about
  on multi monitor. QtWayland already supports it

TEST PLAN
  Unit test

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/registry.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns