D27607: Deprecate KDBusConnectionPool

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R271:417607275368: Deprecate KDBusConnectionPool (authored by 
vkrause).

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27607?vs=76316=76652

REVISION DETAIL
  https://phabricator.kde.org/D27607

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdeinitinterface.cpp

To: vkrause, davidedmundson
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27607: Deprecate KDBusConnectionPool

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause, davidedmundson
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27607: Deprecate KDBusConnectionPool

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27607: Deprecate KDBusConnectionPool

[Volker Krause]

vkrause updated this revision to Diff 76316.
vkrause added a comment.


  Set EXCLUDE_DEPRECATED_BEFORE_AND_AT.

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27607?vs=76241=76316

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27607

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdeinitinterface.cpp

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27607: Deprecate KDBusConnectionPool

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
> +DEPRECATION_VERSIONS 5.68
> +EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT}
> +)

`${EXCLUDE_DEPRECATED_BEFORE_AND_AT}` is not defined by default.

You want to add an option (or actually cached cmake var) in the toplevel 
CMakeLists.txt, lke mentioned in the docs: 
https://api.kde.org/ecm/module/ECMGenerateExportHeader.html
Both to document this flag, as also ensure there the variable is set (did cmake 
not fail for you?):

  set(EXCLUDE_DEPRECATED_BEFORE_AND_AT 0 CACHE STRING "Control the range of 
deprecated API excluded from the build [default=0].")

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27607: Deprecate KDBusConnectionPool

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  As per T12722  this is no longer needed, 
QDBusConnection now behaves
  correctly in a multi-threaded scenario.
  
  All uses found by lxr have either been ported already, or have patches
  in review.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27607

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdeinitinterface.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns