D27614: build: fix the build where install prefix is not user-writable
dfaure added a comment. Nobody cares about broken CI, or my comment here wasn't noticed, so I fixed it myself. https://phabricator.kde.org/D28188 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27614 To: bshah, ngraham, lbeltrame, sitter Cc: dfaure, sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27614: build: fix the build where install prefix is not user-writable
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:17
> +add_custom_target(breeze-generate-24px-versions-dark ALL
> +COMMAND ${BASH_EXE} ${CMAKE_SOURCE_DIR}/generate-24px-versions.sh
> ${CMAKE_CURRENT_BINARY_DIR}/generated/
> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
Any reason for this generated/ subdir?
It breaks symlinks, which only do "../../" because they don't expect to have to
go out of one-more-subdir (and they don't after installation).
See
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/267/testReport/projectroot/autotests/symlink/
Note that symlinktest only checks the source dir (which is another bug), so it
doesn't fail locally if you use a builddir completely outside the srcdir. But
on CI it seems to be a subdir, so the recursive search in the source dir finds
them.
I'm guessing symlinktest should also check the builddir (".") to make such test
failures easier to reproduce no matter what the local setup.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D27614
To: bshah, ngraham, lbeltrame, sitter
Cc: dfaure, sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
D27614: build: fix the build where install prefix is not user-writable
This revision was automatically updated to reflect the committed changes. Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix is not user-writable (authored by bshah). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76278=76279 REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES icons-dark/CMakeLists.txt icons/CMakeLists.txt validate_svg.sh To: bshah, ngraham, lbeltrame, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27614: build: fix the build where install prefix is not user-writable
bshah updated this revision to Diff 76278. bshah added a comment. rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76256=76278 BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES icons-dark/CMakeLists.txt icons/CMakeLists.txt validate_svg.sh To: bshah, ngraham, lbeltrame, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27614: build: fix the build where install prefix is not user-writable
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I'd rather have the excess spaces been done away with. Otherwise LGTM, please rebase and land. REPOSITORY R266 Breeze Icons BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 To: bshah, ngraham, lbeltrame, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27614: build: fix the build where install prefix is not user-writable
lbeltrame added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27614 To: bshah, ngraham, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27614: build: fix the build where install prefix is not user-writable
bshah created this revision. bshah added reviewers: ngraham, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - Validate only the files and symlinks - Fix target names, they were swapped - generate the icons in build-dir and then install it TEST PLAN done make and make install and verified install_manifest.txt looks sane REPOSITORY R266 Breeze Icons BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES icons-dark/CMakeLists.txt icons/CMakeLists.txt validate_svg.sh To: bshah, ngraham, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
