D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions

2020-03-25 Thread Cyril Rossi 
crossi added a comment.


  In D27724#633240 , @davidedmundson 
wrote:
  
  > > Unfortunately, if the user clicks on reset button at first, the apply 
button is disabled an stays disabled.
  >
  > I'm not sure I understand why that would happen.
  >
  > That means there's something else going on, and we shouldn't ship this till 
we understand it.
  
  
  I don't understand either but I didn't investigate deeper.
  From what I have tested, it does not keep in sync setNeedsSave state.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions

2020-03-23 Thread David Edmundson 
davidedmundson retitled this revision from "Syncronise setNeedsSave between 
KCModule and ConfigModule in both directions" to "Synchronise setNeedsSave 
between KCModule and ConfigModule in both directions".

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns