D27795: Expose capture signal on KeySequenceItem

2020-03-02 Thread Ismael Asensio 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:1a838e468d05: Expose capture signal on KeySequenceItem 
(authored by iasensio).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27795?vs=76808=76810

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

2020-03-02 Thread Ismael Asensio 
iasensio updated this revision to Diff 76808.
iasensio marked an inline comment as done.
iasensio added a comment.


  Add API comment

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27795?vs=76807=76808

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

2020-03-02 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> KeySequenceItem.qml:13
>  
> +signal captureFinished()
>  

If you could add API docs that'd be really great

REPOSITORY
  R296 KDeclarative

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

2020-03-02 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27795: Expose capture signal on KeySequenceItem

2020-03-02 Thread Ismael Asensio 
iasensio created this revision.
iasensio added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Expose the signal `captureFinished` from the private helper to 
`KeySequenceItem`.
  Currently, if we set `keySequence` from a model and use 
`onKeySequenceChanged` to
  update that model, a binding loop happens. Using `onCaptureFinished` prevents 
that.

TEST PLAN
keySequence: modelData
onCaptureFinished: { modelData = keySequence }

REPOSITORY
  R296 KDeclarative

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns