D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham added a comment.


  Fixed in 7aaee715aff2a3fadf950f686a8be5e0d49c3297 
 and 
did it the correct way in 1f0cf38dbf2eb7de2b7fe09ef82bbb281a296a68 
. 
Sorry about the breakage.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: broulik, davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27848: Remove the panel tooltip icon

[David Redondo]

davidre added a comment.


  In D27848#643045 , @ngraham wrote:
  
  > See the parent task.
  >
  > This component doesn't only darw system tray tooltips but rather tooltips 
for all panel widgets. The idea was that we don't want icons in *any* of these 
tooltips, because they're either redundant or inconsistent with the icon that 
you're hovering the mouse over. For this patch, I guess I should have marked 
the `icon` parameter as deprecated. I can do that in a follow-up patch.
  >
  > I didn't remove the display of a custom image because I figured that in 
this case, the designer was specifically trying to set something different. But 
maybe that should be deprecated too. Open to opinions.
  >
  > On another note, it would have been nice if these concerns had been brought 
up during the month when the patch was open for review.
  
  
  Wouldn't then be the solution to remove icons to wherever the panel widgets 
set them? And why would a designer only explicitely set images but not icons? 
Also this component does not only draw panel tooltips but also other tooltips, 
for example on the widget edit handle things. 
  Sorry for not noticing earlier

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: broulik, davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27848: Remove the panel tooltip icon

[Kai Uwe Broulik]

broulik added a comment.


  > For all panel widgets
  
  which are all governed by a single place: 
`plasma-desktop/desktoppackage/contents/applet/CompactApplet.qml`
  
  Imho an unacceptable behavior break for a Frameworks component.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: broulik, davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham added a comment.


  See the parent task.
  
  This component doesn't only darw system tray tooltips but rather tooltips for 
all panel widgets. The idea was that we don't want icons in *any* of these 
tooltips, because they're either redundant or inconsistent with the icon that 
you're hovering the mouse over. For this patch, I guess I should have marked 
the `icon` parameter as deprecated. I can do that in a follow-up patch.
  
  I didn't remove the display of a custom image because I figured that in this 
case, the designer was specifically trying to set something different. But 
maybe that should be deprecated too. Open to opinions.
  
  On another note, it would have been nice if these concerns had been brought 
up during the month when the patch was open for review.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27848: Remove the panel tooltip icon

[David Redondo]

davidre added a comment.


  I think this was done at the wrong level. If we don't want icons in the 
systray  then the way would be to net set the property in the systray and not 
ignore the property in the generic component but keep the property for api 
stability purposes. Now we have a component with a documented property that 
doesn't work. People trying to use this will think it's broken while we can't 
use it in any context where we want an icon in the future. Furthermore it's 
inconsistent that one can still set an icon via image strengthening the broken 
look from the outside.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: davidre, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:863ec93adec6: Remove the panel tooltip icon (authored by 
ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27848?vs=76971&id=79368

REVISION DETAIL
  https://phabricator.kde.org/D27848

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27848: Remove the panel tooltip icon

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove, apol
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham added a comment.


  If the #plasma  people accept, this 
would need to wait until Frameworks 5.70 to land or else rolling release 
distros will lose icons in half their tooltips, but not the rest.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27848: Remove the panel tooltip icon

[Nathaniel Graham]

ngraham retitled this revision from "Remove the tooltip icon" to "Remove the 
panel tooltip icon".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack, niccolove
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns