D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-05 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 77029.
ahmadsamir retitled this revision from "[KFileFilterCombo] Don't add inavlid 
QMimeType to mime filter" to "[KFileFilterCombo] Don't add invalid QMimeType to 
mimes filter".
ahmadsamir removed a reviewer: kossebau.
ahmadsamir removed a subscriber: kossebau.
ahmadsamir added a comment.


  Fix typo; fix qt logging bits

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77015&id=77029

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns, 
kossebau

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-05 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:57
> +ecm_qt_declare_logging_category(kiofilewidgets_SRCS
> +HEADER kiofilewidgets_debug.h
> +IDENTIFIER KIO_KFILEWIDGETS_KFILEFILTERCOMBO

Perhaps name the header matching kfilefiltercombo, to make clear this one is 
not providing the general library category.

> kfilefiltercombo.cpp:29
>  #include 
> +#include 
>  

Should not be needed, served by generated header already.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-05 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 77031.
ahmadsamir added a comment.


  Fix _debug.h file name

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77029&id=77031

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-05 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 77032.
ahmadsamir added a comment.


  Remove redundant #include

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77031&id=77032

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-05 Thread Ahmad Samir 
ahmadsamir added a comment.


  FTR, gwenview should be fixed by D27875 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> kfilefiltercombo.cpp:156
> +if (!type.isValid()) {
> +qCDebug(KIO_KFILEWIDGETS_KFILEFILTERCOMBO) << *it << "is not a 
> valid mimeType";
> +continue;

IMHO it's a programmer error so it should be a qCWarning (visible by default), 
not a qCDebug (invisible by default).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 77139.
ahmadsamir added a comment.


  Rebase. Per dfaure's recommendation use qCWarning instead of qCDebug, the 
former is visible by default, which makes sense for a programmer error (feeding 
the open file dialog invalid mimeTypes).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77032&id=77139

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9cb7cf957a1c: [KFileFilterCombo] Don't add invalid 
QMimeType to mimes filter (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77153&id=77154

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

2020-03-06 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 77153.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77139&id=77153

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns