D27893: Use fallback also on Windows not only mac

2020-03-07 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:1b93a366da68: Use fallback also on Windows not only mac 
(authored by vonreth, committed by cullmann).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27893?vs=77095=77176

REVISION DETAIL
  https://phabricator.kde.org/D27893

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27893: Use fallback also on Windows not only mac

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.


  Ok, let's have that be in ;=)

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27893

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Johnny Jazeix
jjazeix accepted this revision.
jjazeix added a comment.


  same, good and cleaner. Thank you!

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27893

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Ben Cooksley
bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.


  Looks good to me!

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27893

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Hannah von Reth
vonreth added reviewers: broulik, bcooksley, jjazeix, cullmann.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27893

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27893: Use fallback also on Windows not only mac

2020-03-06 Thread Hannah von Reth
vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27893

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns