D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

2020-03-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:517bcca389d9: [KCM Controls GridDelegate] Use 
`ShadowedRectangle` (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28028?vs=77567&id=77571

REVISION DETAIL
  https://phabricator.kde.org/D28028

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

2020-03-13 Thread Kai Uwe Broulik
broulik edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

2020-03-13 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

2020-03-13 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of expensive `DropShadow` layer.

TEST PLAN
  Left is before, right is after
  F8174448: Screenshot_20200313_104013.PNG 

  There's a slight difference in falloff but colors and size are spot on

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns