D28093: [breeze-icons] add TeamViewer tray icons

2020-04-28 Thread David Redondo 
davidre added a comment.


  Couldn't we put the tray icon in the plasma theme?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: davidre, IlyaBizyaev, ngraham, ndavis, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-04-28 Thread Nathaniel Graham 
ngraham added a comment.


  Oh gosh, Can confirm. :/
  
  Now we have two icons with different casing: `teamviewer` (colorful, app 
icon) and `TeamViewer` (monochrome, tray icon). I guess the app uses the same 
icon name for its tray icon as its main icon (b) and also KIconLoader isn't 
case-sensitive (b)? Yikes, what a mess. :/ Not sure what we do here TBH

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: IlyaBizyaev, ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-04-28 Thread Ilya Bizyaev 
IlyaBizyaev added a comment.


  When I updated my parents' PC, they lost the TeamViewer desktop icon because 
it became monochrome.
  Confirmed locally, the TeamViewer icon in the Dashboard menu is also 
monochrome.
  This does not happen to the recently introduced Flameshot icon, so what's the 
difference here?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: IlyaBizyaev, ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-18 Thread Nathaniel Graham 
ngraham added a comment.


  That will help for people using thick panels who see larger icons, but users 
of thin panels will still get the monochrome icon.
  
  It's yet another example of our inability to deterministically T10413: Find a 
way to specify whether to use monochrome or color icons in applications 
. :/
  
  That said, TeamViewer changing the icon means that our current `teamviewer` 
icon isn't used at all, so I guess renaming its larger sizes to match the same 
name as the system tray icon would be better than nothing.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-18 Thread Rocket Aaron 
rocka added a comment.


  Could we just create a symlink TeamViewer.svg points to 48px teamviewer.svg? 
And I noticed that in their latest version, they changed the Icon in desktop 
entry file to TeamViewer, and all the installed icons were named TeamViewer.
  
  After creating that symlink, the icon works fine in Task Manager and 
Application Dashboard, but still looks monochrome in Application Launcher and 
Application Menu.
  
  F8183756: a.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-18 Thread Nathaniel Graham 
ngraham added a comment.


  I didn't notice it before, but this patch makes TeamViewer's app icon always 
use the monochrome version now: F8183406: Screenshot_20200318_132426.png 

  
  We already have a Breeze icon for TeamViewer called `teamviewer` note the 
capitalization. It seems like somewhere in our stack, `teamviewer` and 
`TeamViewer` get mixed up such that everything uses the monochrome icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:cff8c406dd71: [breeze-icons] add TeamViewer tray icons 
(authored by rocka, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28093?vs=77810=77851

REVISION DETAIL
  https://phabricator.kde.org/D28093

AFFECTED FILES
  icons-dark/status/22/TeamViewer.svg
  icons/status/22/TeamViewer.svg

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Noah Davis 
ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  teamviewer-tray (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Nathaniel Graham 
ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  teamviewer-tray (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Rocket Aaron 
rocka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Rocket Aaron 
rocka added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28093

To: rocka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Rocket Aaron 
rocka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rocka requested review of this revision.

REVISION SUMMARY
  Created TeamViewer tray icons following Breeze style.

REPOSITORY
  R266 Breeze Icons

BRANCH
  teamviewer-tray (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28093

AFFECTED FILES
  icons-dark/status/22/TeamViewer.svg
  icons/status/22/TeamViewer.svg

To: rocka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns