D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0739113a4477: Make animation durations consistent with 
Kirigami values (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78102=79361

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I reverted this for now in e2a13e9ac79a8d8d8a7dfd0916f6826760b73165 because 
if we land it now before the companion Plasma patches are in, rolling release 
users will suffer from slow animations for a month. I will re-land it after 
Frameworks 5.69 is tagged so that it gets released with Frameworks 5.70, the 
version that Plasma 5.19 will depend on.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham added a dependent revision: D28239: Stop multiplying duration values.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham added a dependent revision: D28238: Stop multiplying duration values.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:049978008b12: Make animation durations consistent with 
Kirigami values (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78036=78102

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham added a dependent revision: D28033: Create ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham updated this revision to Diff 78036.
ngraham added a comment.


  Forgot one more thing

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78035=78036

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham updated this revision to Diff 78035.
ngraham added a comment.


  Don't forget kirigamiplasmastyle

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78031=78035

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now longDuration is 120ms and shortDuration is 24ms. This presents 
three problems:
  
  - The durations are far too fast, especially shortDuration, which is so fast 
that it seems like there is no animation at all.
  - The durations are not consistent with Kirigami, which uses 150 for short 
and 250 for long.
  - There is no longer value available, as with the one being added to Kirigami 
in D28143 .
  
  Accordingly, this patch makes the short and long values consistent with 
Kirigami's values,
  and adds a new `veryLongDuration` value to match the one being added to 
Kirigami in D28143 .

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns