D28191: [KFontChooser] General code cleanup

2020-03-24 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:f22c1864f5c8: [KFontChooser] General code cleanup 
(authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78376&id=78382

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-24 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-24 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 78376.
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Fix, arcanist is

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78375&id=78376

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-24 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 78375.
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Tweak

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78299&id=78375

BRANCH
  l-code-cleanup-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-23 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 78299.
ahmadsamir added a comment.


  Also enable size spinbox when enabling the size list box

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78295&id=78299

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-23 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 78295.
ahmadsamir added a comment.


  Make connect() actually work for the QCheckBoxes

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78265&id=78295

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-22 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 78265.
ahmadsamir added a reviewer: dfaure.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78190&id=78265

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

2020-03-21 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck, apol, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Use new connect syntax
  - Prefix increment where appropriate
  - Replace foreach/iterator-based for with range-for
  - Remove (really) old TODOs

TEST PLAN
  make && ctest
  KFontChooser in e.g. Kate still loads and works as before

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns