D28362: Fix stylesheet linking in 8 icons
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1bbf2a546894: Fix stylesheet linking in 8 icons (authored by davidhurka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78702=78714 REVISION DETAIL https://phabricator.kde.org/D28362 AFFECTED FILES icons/actions/16/distribute-vertical-center.svg icons/actions/16/edit-clear-locationbar-ltr.svg icons/actions/16/mail-reply-all.svg icons/actions/22/distribute-vertical-center.svg icons/actions/22/edit-clear-locationbar-ltr.svg icons/actions/22/kstars_supernovae.svg icons/actions/symbolic/list-remove-symbolic.svg icons/devices/16/network-wireless-connected-25.svg To: davidhurka, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28362: Fix stylesheet linking in 8 icons
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362 To: davidhurka, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28362: Fix stylesheet linking in 8 icons
davidhurka updated this revision to Diff 78702. davidhurka added a comment. - Fix spelling REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78701=78702 BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362 AFFECTED FILES icons/actions/16/distribute-vertical-center.svg icons/actions/16/edit-clear-locationbar-ltr.svg icons/actions/16/mail-reply-all.svg icons/actions/22/distribute-vertical-center.svg icons/actions/22/edit-clear-locationbar-ltr.svg icons/actions/22/kstars_supernovae.svg icons/actions/symbolic/list-remove-symbolic.svg icons/devices/16/network-wireless-connected-25.svg To: davidhurka Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28362: Fix stylesheet linking in 8 icons
davidhurka updated this revision to Diff 78701. davidhurka added a subscriber: ndavis. davidhurka added a comment. @ndavis REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78700=78701 BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362 AFFECTED FILES icons/actions/16/distribute-vertical-center.svg icons/actions/16/edit-clear-locationbar-ltr.svg icons/actions/16/mail-reply-all.svg icons/actions/22/distribute-vertical-center.svg icons/actions/22/edit-clear-locationbar-ltr.svg icons/actions/22/kstars_supernovae.svg icons/actions/symbolic/list-remove-symbolic.svg icons/devices/16/network-wireless-connected-25.svg To: davidhurka Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28362: Fix stylesheet linking in 8 icons
davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY These 8 icons were (partially) not recolored by the stylesheet, because their elements were either not linked to the stylesheet, or had contradicting style information. This adds the missing class attributes and removes the wrong color definitions in the style attributes. Furthermore, I would like to know why icons/actions/symbolic/list-remove-symbolic.svg has an additional stylesheet “current-color-scheme-6”. Is that information available? REPOSITORY R266 Breeze Icons BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362 AFFECTED FILES icons/actions/16/distribute-vertical-center.svg icons/actions/16/edit-clear-locationbar-ltr.svg icons/actions/16/mail-reply-all.svg icons/actions/22/distribute-vertical-center.svg icons/actions/22/edit-clear-locationbar-ltr.svg icons/actions/22/kstars_supernovae.svg icons/actions/symbolic/list-remove-symbolic.svg icons/devices/16/network-wireless-connected-25.svg To: davidhurka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
