D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham added a comment.


  You're welcome!

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston added a comment.


  In D28397#643937 , @ngraham wrote:
  
  > Great patches, @harogaston! Keep 'em coming! :)
  
  
  Yes, quarantine is working good for me ;).
  I've also got a couple of PRs on Konsole.
  Thank you for your work and support @ngraham !

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham added a comment.


  Great patches, @harogaston! Keep 'em coming! :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:5613fd66c5f4: Replace Vokoscreen with VokoscreenNG 
(authored by harogaston, committed by ngraham).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28397?vs=79185&id=79611

REVISION DETAIL
  https://phabricator.kde.org/D28397

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/vokoscreen.desktop
  data/kmoretools-desktopfiles/vokoscreen.png
  data/kmoretools-desktopfiles/vokoscreenNG.desktop
  data/kmoretools-desktopfiles/vokoscreenNG.png
  src/kmoretools/kmoretoolspresets.cpp

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Thanks! I will commit this tomorrow after branching as we don't typically 
change translated strings within two weeks of branding, so as to give the 
translators time to translate them.

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston updated this revision to Diff 79185.
harogaston added a comment.


  Removed unnesessary changes to .desktop as indicated

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28397?vs=78778&id=79185

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/vokoscreen.desktop
  data/kmoretools-desktopfiles/vokoscreen.png
  data/kmoretools-desktopfiles/vokoscreenNG.desktop
  data/kmoretools-desktopfiles/vokoscreenNG.png
  src/kmoretools/kmoretoolspresets.cpp

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Aleix Pol Gonzalez]

apol added a comment.


  In D28397#638434 , @harogaston 
wrote:
  
  > In D28397#637602 , @pino wrote:
  >
  > > please do //not// change translated keys (eg `Name[lang]`) in 
desktop-alike files when you change the English string: we have a system in 
place to handle translations
  >
  >
  > Do I need to address this or is it a recommendation? I had no idea about 
that, soory.
  
  
  Just change the Name= part, the rest will get automatically repopulated by 
magical CI scripts.

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston added a comment.


  In D28397#637602 , @pino wrote:
  
  > please do //not// change translated keys (eg `Name[lang]`) in desktop-alike 
files when you change the English string: we have a system in place to handle 
translations
  
  
  Do I need to address this or is it a recommendation? I had no idea about 
that, soory.

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Pino Toscano]

pino added a comment.


  please do //not// change translated keys (eg `Name[lang]`) in desktop-alike 
files when you change the English string: we have a system in place to handle 
translations

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: leinir.
ngraham added a comment.
This revision is now accepted and ready to land.


  It's also in openSUSE Tumbleweed, FWIW--where it's replaced the old 
Vokoscreen entirely.
  
  Since the newer distros that will get a new KNewStuff are also going to be 
the ones that are the most likely to be packaging the new version, I think it 
makes sense to do this--the only question is the timing. Do it now, or wait a 
month or two or three? Doing it now makes sense to me since the distros that 
don't yet have VokoscreenNG probably will by the time they update to Frameworks 
5.59. It's always annoying when apps do this kind of thing, but we need to 
adapt IMO.
  
  Thoughts?

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham, leinir
Cc: IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston added a comment.


  In D28397#637193 , @IlyaBizyaev 
wrote:
  
  > It seems that of released distros, only Fedora has vokoscreenNG in 
repositories so far
  
  
  It's in the AUR also https://aur.archlinux.org/packages/vokoscreen but I can 
see your point.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham
Cc: IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  It seems that of released distros, only Fedora has vokoscreenNG in 
repositories so far

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham
Cc: IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston edited the summary of this revision.
harogaston edited the test plan for this revision.
harogaston added reviewers: KNewStuff, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28397

To: harogaston, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
harogaston requested review of this revision.

REVISION SUMMARY
  The original Vokoscreen project has been abandoned
  
 and superseeded by VokoscreenNG. This patch updates
 the references.
 BUG: 416460 417575

TEST PLAN
  Spectacle -> Tools -> Record Screen the new
  
   VokoscreenNG entry should appear and the new
   website referenced. (If other tools are installed
   it will appear under "More")

REPOSITORY
  R304 KNewStuff

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/vokoscreen.desktop
  data/kmoretools-desktopfiles/vokoscreen.png
  data/kmoretools-desktopfiles/vokoscreenNG.desktop
  data/kmoretools-desktopfiles/vokoscreenNG.png
  src/kmoretools/kmoretoolspresets.cpp

To: harogaston
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns