D28520: Fix lifetime of slot in KIO-MTP
This revision was automatically updated to reflect the committed changes. Closed by commit R320:f4e0183adfd8: Fix lifetime of slot in KIO-MTP (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28520?vs=79196&id=79609 REVISION DETAIL https://phabricator.kde.org/D28520 AFFECTED FILES mtp/kio_mtp.cpp To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
elvisangelaccio accepted this revision. elvisangelaccio added a comment. Please push to 20.04, there is still time. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
meven accepted this revision. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
apol accepted this revision. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
feverfew added a comment. @apol just found another one where this occurs, forgot about it but noticed it earlier as well. This doesn't affect KIOFuse as much though (as we don't listen to the processedSize() signal). I'll wait for another approval, or before 20.04 tagging, whichever comes first :P REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
feverfew updated this revision to Diff 79196. feverfew added a comment. - Fix another slot lifetime REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28520?vs=79154&id=79196 BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 AFFECTED FILES mtp/kio_mtp.cpp To: feverfew, akrutzler, dfaure, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28520: Fix lifetime of slot in KIO-MTP
feverfew created this revision. feverfew added reviewers: akrutzler, dfaure, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This slot was incorrectly made to last the lifetime of the slave. In fact, this slot should only be live for the lifetime of the event loop (one I/O operation). This can cause issues with the data being emitted for data from other IO operations. By making it live in the lifetime of the local event loop this scenario cannot occur as LIBMTP only allows one operation at a time. TEST PLAN Via the use of KIOFuse (as this is where the bug was noticed). Before: Opening a file for the first time worked. Subsequent opens would fail due to garbage output After: Opening any number of files at any time works. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 AFFECTED FILES mtp/kio_mtp.cpp To: feverfew, akrutzler, dfaure, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
