D28540: Fix layout in DownloadItemsSheet

2020-04-03 Thread Dan Leinir Turthra Jensen 
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The previous code was primarily there to work around misfeatures of 
OverlaySheet which no longer exist. Consequently, we don't have to leave in the 
hacks. Nice.
  
  This further builds on the new OverlaySheet work done by Marco. The whole 
thing works much better, and with less client code. Nice.
  
  BUG:419535

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-downloaditemssheet-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28540

AFFECTED FILES
  src/qtquick/qml/DownloadItemsSheet.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

2020-04-03 Thread Dan Leinir Turthra Jensen 
leinir edited the summary of this revision.
leinir added reviewers: Frameworks, bugseforuns, mart, Plasma, KNewStuff.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28540

To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

2020-04-03 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-downloaditemssheet-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28540

To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

2020-04-04 Thread Dan Leinir Turthra Jensen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:449d056a2d77: Fix layout in DownloadItemsSheet (authored 
by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28540?vs=79226&id=79290

REVISION DETAIL
  https://phabricator.kde.org/D28540

AFFECTED FILES
  src/qtquick/qml/DownloadItemsSheet.qml

To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns