D28582: KRunner: Show error message for Actions in dbus runner
alex added a comment. I am also going to try a friendly ping here :-). REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D28582 To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28582: KRunner: Show error message for Actions in dbus runner
alex updated this revision to Diff 79377. alex added a comment. Update comment REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79376=79377 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D28582 AFFECTED FILES src/dbusrunner.cpp To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28582: KRunner: Show error message for Actions in dbus runner
alex updated this revision to Diff 79376. alex added a comment. Update if condition REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79375=79376 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D28582 AFFECTED FILES src/dbusrunner.cpp To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28582: KRunner: Show error message for Actions in dbus runner
alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY KRunner now shows error messages for the Actions dbus request. But they get only shown if the service is not unknown, because the same error message will be shown in the match method. TEST PLAN Make sure that the logging category is enabled and verify that you get debug output when starting KRunner. Create a runner for example https://cgit.kde.org/scratch/davidedmundson/pythonrunner.git/tree/runner.py and install it. Make sure that the Actions method is valid and returns actions, they should be displayed without warnings. Change the return value from a list to 123, a TypeError message should be displayed. Kill the runner, and type one letter in KRunner. The ServiceUnknown error message gets shown only once (from the match method). REPOSITORY R308 KRunner BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D28582 AFFECTED FILES src/dbusrunner.cpp To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
