D29084: Make the HTML file template more useful

2020-04-27 Thread Grzegorz Szymaszek 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5adaa7cba102: Make the HTML file template more useful 
(authored by gszymaszek).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80859=81360

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek 
gszymaszek requested review of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29084

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek 
gszymaszek updated this revision to Diff 80859.
gszymaszek added a comment.


  - Add common HTML elements to the HTML file template

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80853=80859

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan 
ognarb added a comment.


  In D29084#654489 , @gszymaszek 
wrote:
  
  > In D29084#654484 , @ognarb wrote:
  >
  > > - Don't include

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek 
gszymaszek updated this revision to Diff 80853.
gszymaszek added a comment.


  - Remove stylesheets from the HTML file template

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80839=80853

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek 
gszymaszek added a comment.


  In D29084#654484 , @ognarb wrote:
  
  > - Don't include

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan 
ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  Good idea to improve the default HTML file.
  
  Improvement ideas:
  
  - Don't include

D29084: Make the HTML file template more useful

2020-04-22 Thread Ahmad Samir 
ahmadsamir added reviewers: Frameworks, dfaure, ognarb.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29084

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

2020-04-22 Thread Grzegorz Szymaszek 
gszymaszek created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gszymaszek requested review of this revision.

REVISION SUMMARY
  This commit removes the empty meta tag and adds the following:
  
  - a DOCTYPE declaration,
  - an html[lang] attribute,
  - a document charset declaration,
  - a newline at the end of the document.
  
  Adding the DOCTYPE and charset make the template HTML5‐complant.
  
  BUG: 419935

REPOSITORY
  R241 KIO

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns