D29191: [FileWatch] Fix watch updates on config changes

2020-04-26 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c76397081d1e: [FileWatch] Fix watch updates on config 
changes (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29191?vs=81206=81243

REVISION DETAIL
  https://phabricator.kde.org/D29191

AFFECTED FILES
  autotests/unit/file/filewatchtest.cpp
  src/file/filewatch.cpp
  src/file/filewatch.h

To: bruns, #baloo, ngraham, meven
Cc: meven, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D29191: [FileWatch] Fix watch updates on config changes

2020-04-26 Thread Stefan Brüns 
bruns edited the summary of this revision.
bruns added a dependency: D29189: [KInotify] Fix path matching when removing 
watches.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D29191

To: bruns, #baloo, ngraham, meven
Cc: meven, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D29191: [FileWatch] Fix watch updates on config changes

2020-04-26 Thread Méven Car 
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Good to me

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D29191

To: bruns, #baloo, ngraham, meven
Cc: meven, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D29191: [FileWatch] Fix watch updates on config changes

2020-04-25 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Track the current list of include/exclude folders, and on a config change
  add/remove watches for the differences. Previously, when an include
  folder was removed the corresponding watches were never removed.
  
  Depends on D29190 

TEST PLAN
  ctest -R filewatchtest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D29191

AFFECTED FILES
  autotests/unit/file/filewatchtest.cpp
  src/file/filewatch.cpp
  src/file/filewatch.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams