D29314: [PlasmaCore.IconItem] Regression: fix crash on source change
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b0d4c4bdaed: [PlasmaCore.IconItem] Regression: fix crash on source change (authored by kmaterka). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29314?vs=81629&id=81631 REVISION DETAIL https://phabricator.kde.org/D29314 AFFECTED FILES src/declarativeimports/core/iconitem.cpp To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29314: [PlasmaCore.IconItem] Regression: fix crash on source change
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. This also fixes another crash I was seeing with the ExpandableListItem applets. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29314: [PlasmaCore.IconItem] Regression: fix crash on source change
ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29314: [PlasmaCore.IconItem] Regression: fix crash on source change
kmaterka edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29314: [PlasmaCore.IconItem] Regression: fix crash on source change
kmaterka edited the summary of this revision. kmaterka edited the test plan for this revision. kmaterka added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29314 To: kmaterka, #plasma, #frameworks, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29314: [PlasmaCore.IconItem] Regression: fix crash on source change
kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY When SvgSource is changed, old one is deleted. Connections are not automatically disconected. This change disconnects connections. TEST PLAN STEPS TO REPRODUCE 1. click on mute button for a device 2. click on the desktop to collapse the applet OBSERVED RESULT crash in step 1 and in the rare case it doesn't crash it crash in step 2 EXPECTED RESULT don't crash BUG: 420801 REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29314 AFFECTED FILES src/declarativeimports/core/iconitem.cpp To: kmaterka, #plasma, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
