D29357: Display rich text notification messages on Android (API level 24+)

[Volker Krause]

vkrause updated this revision to Diff 82566.
vkrause added a comment.


  Support API level < 24 as well.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29357?vs=81729=82566

BRANCH
  rich-text

REVISION DETAIL
  https://phabricator.kde.org/D29357

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, tfella
Cc: z3ntu, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Luca Weiss]

z3ntu added a comment.


  I don't see a reason why rich text should be limited to API24+? Yes, the 
`fromHtml(String source, int flags)` method is API 24+ but for APIs lower than 
that you can use `fromHtml(String source)` as for example wrapped in 
`androidx.core.text.HtmlCompat`:
  
/**
* Invokes {@link Html#fromHtml(String, int)} on API 24 and newer, 
otherwise {@code flags} are
* ignored and {@link Html#fromHtml(String)} is used.
*/
@NonNull
public static Spanned fromHtml(@NonNull String source, @FromHtmlFlags int 
flags) {
if (Build.VERSION.SDK_INT >= 24) {
return Html.fromHtml(source, flags);
}
//noinspection deprecation
return Html.fromHtml(source);
}

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause, tfella
Cc: z3ntu, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Tobias Fella]

tfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause, tfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29357

AFFECTED FILES
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29357: Display rich text notification messages on Android (API level 24+)

[Volker Krause]

vkrause added a comment.


  Example: F8278136: Screenshot_20200502_112835.PNG 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29357

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns