D29455: KNS: Remove isRemote method and handle parse error properly

[Dan Leinir Turthra Jensen]

leinir requested changes to this revision.
leinir added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> installation.h:76
>  bool readConfig(const KConfigGroup );
> -bool isRemote() const;
>  

i'm afraid this is an exported class, at most we can mark this as deprecated 
(with a bit of explanation), we can't remove it...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29455

To: alex, #knewstuff, ngraham, leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29455: KNS: Remove isRemote method and handle parse error properly

[Alexander Lohnau]

alex created this revision.
alex added reviewers: KNewStuff, ngraham, leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  The isRemote check and the FIXMEs are removed, instead the result from the 
empty target check is properly handled.
  
  The same check as in isRemote is done in the Installation::readConfig method 
(line 122).
  If this fails a warning is given and in the engine is an error emitted. This 
error gets shown in the GUI.
  Then there are no other checks needed.

TEST PLAN
  Delete the line TargetDir from the dolphin servicemenu knsrc file.
  (Dolphin repository src/settings/services/servicemenu.knsrc).
  
  Before:
  F8256199: Screenshot_20200423_202404.png 

  After, an error message is shown:
  F8256197: Screenshot_20200423_202239.png 


REPOSITORY
  R304 KNewStuff

BRANCH
  fix_isremote_stuff (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29455

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h

To: alex, #knewstuff, ngraham, leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns