D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R175:7f7533260efc: holidayregion.cpp - provide translatable 
strings for the German regions. (authored by winterz).

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29575?vs=82442=82525

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  src/holidayregion.cpp

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz updated this revision to Diff 82442.
winterz added a comment.


  QLatin1-ify

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29575?vs=82398=82442

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  src/holidayregion.cpp

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz updated this revision to Diff 82398.
winterz added a comment.


  don't try to provide translatable string for unknown subdivisions

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29575?vs=82396=82398

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  src/holidayregion.cpp

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Luigi Toscano]

ltoscano added a comment.


  In D29575#667175 , @winterz wrote:
  
  > I'm guessing it's ok to depend on K5I18N ?
  
  
  KHolidays is a Tier 1 framework, so it can't depend on KI18n. Just use 
QCoreApplication::translate as used already in src/holidayregion.cpp.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz added a comment.


  I'm guessing it's ok to depend on K5I18N ?

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

[Allen Winter]

winterz created this revision.
winterz added a reviewer: vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
winterz requested review of this revision.

REVISION SUMMARY
  The German holiday files now all have a proper country and name
  since commits 4bdc6f618e77348eeafa5e802154b95febc27eab 

  and 8b3f65ed1f40975aa559881fc3116029b7e7677e 

  
  this patch allows those names to be translated.
  
  also we can see the subdivision code in the regionName
  in the case we have a subdivision but no name.
  i.e say we have country "XX-YY" but name field is empty
  then we have regionName = countyCode(XX)(yy)

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29575

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/holidayregion.cpp

To: winterz, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns