D4716: Add some more directives to MIPS assembler highlighting
arichardson added a comment. Sorry, was busy with other stuff so completely forgot about this. I'll update this soon. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D4716: Add some more directives to MIPS assembler highlighting
dhaumann added a comment. @arichardson friendly ping :-) In case you don't have the time, it's also OK to paste some example code in a comment here (MIT licensed, please). Then, we can proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D4716: Add some more directives to MIPS assembler highlighting
dhaumann added a comment. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Could you provide a test snippet now? I will integrate this then. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann, #frameworks
D4716: Add some more directives to MIPS assembler highlighting
arichardson updated this revision to Diff 30212. arichardson marked 2 inline comments as done. arichardson added a comment. address comments will try to add tests soon REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4716?vs=11618=30212 BRANCH arcpatch-D4716 REVISION DETAIL https://phabricator.kde.org/D4716 AFFECTED FILES data/syntax/c-preprocessor.xml data/syntax/gnuassembler.xml data/syntax/mips.xml To: arichardson, dhaumann, vkrause Cc: #frameworks, michaelh, ngraham
D4716: Add some more directives to MIPS assembler highlighting
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. ping? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: #frameworks
[Differential] [Updated] D4716: Add some more directives to MIPS assembler highlighting
dhaumann added a comment. I think in general a good idea. Some comments: - Could you update the patch with the mentioned issues? - Could you also provide two test cases (under MIT license) that demonstrate MIPS and GNU Assembler highlighting? That would be very helpful for our unit tests. INLINE COMMENTS > c-preprocessor.xml:13-14 > +section="Other" > + > extensions="*.c++;*.cxx;*.cpp;*.cc;*.C;*.h;*.hh;*.H;*.h++;*.hxx;*.hpp;*.hcc;*.S" > +mimetype="text/x-c++src;text/x-c++hdr;text/x-chdr;text/x-csrc" > +author="Alex Richardson (arichardson@gmail.com)" I would prefer extensions="" mimetype="" hidden="true" priority="1" > c-preprocessor.xml:16 > +author="Alex Richardson (arichardson@gmail.com)" > +license="LGPL" > +hidden="true" Are you also ok with MIT license? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: arichardson, vkrause, dhaumann Cc: #frameworks
[Differential] [Request, 255 lines] D4716: Add some more directives to MIPS assembler highlighting
arichardson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add a few 64-bit MIPS instruction mnemonics Add c-preprocessor.xml highlighting file to be included Extracted and slightly modified from isocpp.xml Make GNU Assembler and MIPS assembler use c-preprocessor.xml This fixes highlighting of e.g. #include REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D4716 AFFECTED FILES data/syntax/c-preprocessor.xml data/syntax/gnuassembler.xml data/syntax/mips.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: arichardson, dhaumann, vkrause Cc: #frameworks
