D5134: Don't exit if $DISPLAY is not set

2017-05-27 Thread Albert Astals Cid
aacid abandoned this revision.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D5134

To: aacid, graesslin
Cc: graesslin, rikmills, lukas, #frameworks


D5134: Don't exit if $DISPLAY is not set

2017-03-23 Thread Albert Astals Cid
aacid added a comment.


  > Kinit if built with X11 is still requiring the DISPLAY variable all over 
the place. The only solution is to run an X server, even if it is not the X 
platform As we do on Plasma/Wayland
  
  I don't know what you mean by "only solution" because with this change things 
seem to work fine for me (and I'm not running an X server)
  
  Reading the code the only thing that seems I am missing is startup 
notification.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D5134

To: aacid, graesslin
Cc: graesslin, rikmills, lukas, #frameworks


D5134: Don't exit if $DISPLAY is not set

2017-03-22 Thread Martin Gräßlin
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  As I stumbled over that years ago: sorry I don't think that this is the 
proper solution. This is basically https://phabricator.kde.org/T4431 which is 
not yet implemented. What this change suggest is a rather hacky solution.
  
  Kinit if built with X11 is still requiring the DISPLAY variable all over the 
place. The only solution is to run an X server, even if it is not the X 
platform As we do on Plasma/Wayland

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D5134

To: aacid, graesslin
Cc: graesslin, rikmills, lukas, #frameworks


D5134: Don't exit if $DISPLAY is not set

2017-03-22 Thread Albert Astals Cid
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The fact that kinit was build with X11 doesn't mean it will be using X11 at 
runtime

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5134

AFFECTED FILES
  src/kdeinit/kinit.cpp
  src/wrapper.cpp

To: aacid
Cc: #frameworks