D5745: recreate plasmashellsurf on exposed, destoy on hidden
This revision was automatically updated to reflect the committed changes. Closed by commit R242:fd2e850156ac: recreate plasmashellsurf on exposed, destoy on hidden (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14435=14436 REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma, #plasma_on_wayland, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart updated this revision to Diff 14435. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14247=14435 BRANCH arcpatch-D5745 REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma, #plasma_on_wayland, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. some code comments would be good. you can copy update https://phabricator.kde.org/T6064 REPOSITORY R242 Plasma Framework (Library) BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 To: mart, #plasma, #plasma_on_wayland, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart added a reviewer: Plasma on Wayland. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5745 To: mart, #plasma, #plasma_on_wayland Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart updated this revision to Diff 14247. mart added a comment. - don't return false REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14246=14247 BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart updated this revision to Diff 14246. mart added a comment. - check null region REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14241=14246 BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
davidedmundson added inline comments.
INLINE COMMENTS
> dialog.cpp:1123
> if (event->type() == QEvent::Expose) {
> -// FIXME TODO: We can remove this once we depend on Qt 5.6.1+.
> -// See: https://bugreports.qt.io/browse/QTBUG-26978
> -KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager);
> +if (!d->shellSurface) {
> +KWindowSystem::setState(winId(), NET::SkipTaskbar |
> NET::SkipPager);
we also get an expose on hide, but with a null region.
Can you add:
auto ee = static_cast(event);
+if (ee->region().isNull()) {
+return false;
+}
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5745
To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5745: recreate plasmashellsurf on exposed, destoy on hidden
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY every time the window gets shown the wayland surfaces get created, when hidden, they get destroyed showevent is too early for it as they aren't there yet, use :Exposed instead, but only the first time when the surface isn't there yet TEST PLAN popup applets always have correct blur in a wayland session REPOSITORY R242 Plasma Framework (Library) BRANCH phab/recreateshell REVISION DETAIL https://phabricator.kde.org/D5745 AFFECTED FILES src/declarativeimports/core/tooltipdialog.cpp src/plasmaquick/dialog.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
