D5828: fix plasma-frameworks build without kwayland

2017-05-13 Thread Allen Winter 
winterz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  fixes the compile errors in plasmaquick/dialog.cpp if you don't have kwayland

TEST PLAN
  compile it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: winterz, mart
Cc: #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-05-13 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> dialog.cpp:1141
>  KWindowSystem::setState(winId(), NET::SkipTaskbar | 
> NET::SkipPager);
>  d->setupWaylandIntegration();
>  d->updateVisibility(true);

Maybe we should only wrap this one function call?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart
Cc: apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-03 Thread David Faure 
dfaure added a comment.


  Ping? This was reported by the packagers for KF5.35 as a build error, and it 
seems the patch just needs review/approval.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-03 Thread David Faure 
dfaure added a reviewer: davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-03 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> apol wrote in dialog.cpp:1141
> Maybe we should only wrap this one function call?

The error message is dialog.cpp:1166:17: error: ‘class 
PlasmaQuick::DialogPrivate’ has no member named ‘shellSurface’, so no.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-05 Thread Bhushan Shah 
bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson, bshah
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-05 Thread Bhushan Shah 
bshah added a reviewer: Plasma.
bshah added a comment.


  Still for 2nd review, adding Plasma as reviewer

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-05 Thread David Edmundson 
davidedmundson accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-05 Thread Marco Martin 
mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol, #frameworks

D5828: fix plasma-frameworks build without kwayland

2017-06-05 Thread Allen Winter 
winterz closed this revision.
winterz added a comment.


  committed  
https://phabricator.kde.org/R242:6c03c15c08a4b585bc3f320865858e4c2832f70b

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5828

To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol, #frameworks