D6008: Give a parent to KMoreToolsMenuFactory menus

2017-07-10 Thread Elvis Angelaccio 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:0b44a25b5df4: Give a parent to KMoreToolsMenuFactory 
menus (authored by elvisangelaccio).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6008?vs=15197&id=16464#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6008?vs=15197&id=16464

REVISION DETAIL
  https://phabricator.kde.org/D6008

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp
  src/kmoretools/kmoretoolsmenufactory.h

To: elvisangelaccio, mart, #frameworks, dfaure
Cc: #frameworks

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-07-01 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6008

To: elvisangelaccio, mart, #frameworks, dfaure
Cc: #frameworks

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-06-29 Thread Elvis Angelaccio 
elvisangelaccio added a reviewer: Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6008

To: elvisangelaccio, mart, #frameworks
Cc: #frameworks

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-06-27 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Ping?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6008

To: elvisangelaccio, mart
Cc: #frameworks

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-06-06 Thread Elvis Angelaccio 
elvisangelaccio updated this revision to Diff 15197.
elvisangelaccio added a comment.


  - Bumped @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6008?vs=14932&id=15197

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6008

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp
  src/kmoretools/kmoretoolsmenufactory.h

To: elvisangelaccio, mart
Cc: #frameworks

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-05-29 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Note: we could also deprecate the current createMenuFromGroupingNames() in 
favor of a new createMenuFromGroupingNames() that takes an addition QWidget* 
argument. Not sure which way is the best.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6008

To: elvisangelaccio, mart
Cc: #frameworks

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-05-29 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  A QMenu without a parent will be wrongly positioned on Wayland.

TEST PLAN
  KMoreToolsMenuFactory menu in Dolphin status bar now works on wayland

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6008

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp
  src/kmoretools/kmoretoolsmenufactory.h

To: elvisangelaccio, mart
Cc: #frameworks