D6199: Allow deleting from write-protected location in dolphin

2018-04-17 Thread Chinmoy Ranjan Pradhan 
chinmoyr abandoned this revision.
chinmoyr added a comment.


  Not required due to design changes

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6199

To: chinmoyr, elvisangelaccio, #frameworks, #dolphin
Cc: Zren, dfaure, #konqueror

D6199: Allow deleting from write-protected location in dolphin

2017-06-17 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> dolphinview.cpp:667
>  const QList list = simplifiedSelectedUrls();
> +KFileItemList itemList;
> +foreach(QUrl u , list) {

itemList.reserve(list.count());

> dolphinview.cpp:668
> +KFileItemList itemList;
> +foreach(QUrl u , list) {
> +KFileItem i(u);

for (const QUrl  : list) {

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6199

To: chinmoyr, elvisangelaccio, #frameworks, #dolphin
Cc: dfaure, #konqueror

D6199: Allow deleting from write-protected location in dolphin

2017-06-17 Thread Chinmoy Ranjan Pradhan 
chinmoyr updated this revision to Diff 15518.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6199?vs=15390=15518

REVISION DETAIL
  https://phabricator.kde.org/D6199

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/views/dolphinview.cpp

To: chinmoyr, elvisangelaccio, #frameworks, #dolphin
Cc: #konqueror

D6199: Allow deleting from write-protected location in dolphin

2017-06-12 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
Restricted Application added a subscriber: Konqueror.

REVISION SUMMARY
  This is a temporary patch which allows deleting items from write-protected 
location. This is only for testing the diff's https://phabricator.kde.org/D6197 
and https://phabricator.kde.org/D6198.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6199

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/views/dolphinview.cpp

To: chinmoyr, elvisangelaccio, #frameworks, #dolphin
Cc: #konqueror