D6250: Expand documentation of Persistence attribute
This revision was automatically updated to reflect the committed changes. Closed by commit R283:8352c0d49eeb: Expand documentation of Persistence attribute (authored by elvisangelaccio). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6250?vs=15928=15929 REVISION DETAIL https://phabricator.kde.org/D6250 AFFECTED FILES src/kauthactionreply.h To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson
D6250: Expand documentation of Persistence attribute
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D6250 To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson
D6250: Expand documentation of Persistence attribute
elvisangelaccio edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D6250 To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson
D6250: Expand documentation of Persistence attribute
elvisangelaccio updated this revision to Diff 15928. elvisangelaccio added a comment. - Explain what happens when the persistence attribute is missing. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6250?vs=15519=15928 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6250 AFFECTED FILES src/kauthactionreply.h To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson
D6250: Expand documentation of Persistence attribute
davidedmundson added a comment. Right, there's 2 valid options if it's set, session and always. Which as you say behave the same. and an implicit third option, not setting it at all. Which does have a different behaviour to the above. I think that needs clearing up in the docs with a line: " - not set: authorization will be queried every time" REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D6250 To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson
D6250: Expand documentation of Persistence attribute
chinmoyr added a comment.
In policy-gen.cpp there is this condition
if (persistence != QLatin1String("session") && persistence !=
QLatin1String("always")) {
qCritical("Wrong persistence: %s", persistence.toLatin1().data());
exit(1);
}
So, if there is persistence then it can't be just set to anything, it has to
be either 'session' or 'always', then only it would append '_keep'.
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D6250
To: elvisangelaccio, #frameworks, davidedmundson
Cc: chinmoyr, davidedmundson
D6250: Expand documentation of Persistence attribute
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Polkit-1 has the a concept of persistence, under a different name. A policy
can be set to:
- auth_admin
- auth_admin_keep
policy-gen-polkit1.cpp chooses between these using the persistence flag
if (!action.persistence.isEmpty() && policy != QLatin1String("yes") &&
policy !=
QLatin1String("no")) {
policy += QLatin1String("_keep");
}
Which is saying if persistence is set to anything and the policy is either
"auth" or "auth_self" append "_keep"
Granted that doesn't match the current docs, but WRT
https://phabricator.kde.org/D6198 we can delete that persistence attribute and
it won't linger.
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D6250
To: elvisangelaccio, #frameworks, davidedmundson
Cc: davidedmundson
D6250: Expand documentation of Persistence attribute
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Add a note that the 'session' and 'always' values are meaningless with the polkit-1 backend, and explain what they actually do. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D6250 AFFECTED FILES src/kauthactionreply.h To: elvisangelaccio, #frameworks
