D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY one should delete the QMediaPlayer in the owner thread to avoid crash TEST PLAN Tested with visual studio 2015 build on Windows REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6317 AFFECTED FILES src/extractors/qtmultimediaextractor.cpp To: mgallien, kde-frameworks-devel Cc: #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien edited reviewers, added: Frameworks; removed: kde-frameworks-devel. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks Cc: #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien added a comment. Ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks Cc: #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Can't you just parent the extractor to the mRunnerThread? Would be all round cleaner REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks, davidedmundson Cc: davidedmundson, #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien added a comment. The problem is that, on Windows, internal objects of QMediaPlayer need to be destroyed in the context of the thread where they have been created. I am not sure making mMetadataExtractor have mRunnerThread as its parent will help on that. I can test but have no Windows around currently to do the test. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks, davidedmundson Cc: davidedmundson, #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien added a comment. Sorry for the delay, currently I have no easy access to a development computer running Windows. David, I am afraid I have not understood correctly your suggestion. Did you suggest to make mMetadataExtractor have its thread as Qt parent ? REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks, davidedmundson Cc: davidedmundson, #frameworks
D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor
mgallien abandoned this revision. mgallien added a comment. I do not have time to properly work on that. See https://phabricator.kde.org/D8886 . REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D6317 To: mgallien, #frameworks, davidedmundson Cc: davidedmundson, #frameworks
