D6535: Use mutually exclusive group in Default Mark Type

2017-07-09 Thread Kevin Funk 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:98aec940ec0b: Use mutually exclusive group in Default Mark 
Type (authored by kfunk).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6535?vs=16285=16417

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk, cullmann
Cc: cullmann, croick, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-09 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable, feel free to commit it ;=)

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

To: kfunk, cullmann
Cc: cullmann, croick, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-07 Thread Kevin Funk 
kfunk updated this revision to Diff 16285.
kfunk added a comment.


  Fix logic. Sorry, must have been asleep here... :\

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6535?vs=16284=16285

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk
Cc: croick, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-07 Thread Kevin Funk 
kfunk updated this revision to Diff 16284.
kfunk added a comment.


  Simplify code, address concerns

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6535?vs=16265=16284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk
Cc: croick, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-07 Thread Christoph Roick 
croick added inline comments.

INLINE COMMENTS

> kateviewhelpers.cpp:2257
>  dMA = selectDefaultMark.addAction(i18n("Mark Type %1",  bit + 
> 1));
> +selectDefaultMarkActionGroup->addAction(dMA);
>  }

this could be done once, after the if-else-block

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6535

To: kfunk
Cc: croick, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-06 Thread Kevin Funk 
kfunk edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6535

To: kfunk
Cc: kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-06 Thread Kevin Funk 
kfunk updated this revision to Diff 16265.
kfunk added a comment.


  Polish commit message

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6535?vs=16264=16265

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk
Cc: kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

2017-07-06 Thread Kevin Funk 
kfunk created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Before:
  
  Set Default Mark Type:
  
  [ ] Bookmark
  [X] Breakpoint
  
  After:
  
  Set Default Mark Type:
  
( ) Bookmark
(x) Breakpoint
  
  Follow-up on KDevelop patch:
  
https://phabricator.kde.org/D6179

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6535

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: kfunk
Cc: kwrite-devel, #frameworks