D6547: Fix build with Qt 5.9.1 and clang

2017-07-08 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:97ce7535124a: Fix build with Qt 5.9.1 and clang (authored 
by elvisangelaccio).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6547?vs=16293&id=16360

REVISION DETAIL
  https://phabricator.kde.org/D6547

AFFECTED FILES
  src/klocalizedstring.h

To: elvisangelaccio, #frameworks, kfunk


D6547: Fix build with Qt 5.9.1 and clang

2017-07-07 Thread Kevin Funk
kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6547

To: elvisangelaccio, #frameworks, kfunk


D6547: Fix build with Qt 5.9.1 and clang

2017-07-07 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D6547

To: elvisangelaccio, #frameworks


D6547: Fix build with Qt 5.9.1 and clang

2017-07-07 Thread Elvis Angelaccio
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Qt 5.9.1 expands Q_REQUIRED_RESULT to the 
 attribute (see
  commit d254d8c19 in qtbase). This breaks the build with clang compilers
  because  cannot be used at the end 
of a function
  declaration:
  
error: 'nodiscard' attribute cannot be applied to types
  
  For the record, GCC just issues a 'attribute ignored' warning when
   is used at the end of a 
declaration.

TEST PLAN
  ki18n now builds with clang + Qt 5.9.1

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6547

AFFECTED FILES
  src/klocalizedstring.h

To: elvisangelaccio, #frameworks