D6683: [server] Send keyboard leave when client destroys the focused surface
This revision was automatically updated to reflect the committed changes. Closed by commit R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6683?vs=16755&id=16775#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6683?vs=16755&id=16775 REVISION DETAIL https://phabricator.kde.org/D6683 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/keyboard_interface.cpp src/server/resource.cpp src/server/resource.h To: graesslin, #frameworks, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6683: [server] Send keyboard leave when client destroys the focused surface
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH keyboard-leave-surface-destroy REVISION DETAIL https://phabricator.kde.org/D6683 To: graesslin, #frameworks, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6683: [server] Send keyboard leave when client destroys the focused surface
graesslin updated this revision to Diff 16755. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Add nullptr check to prevent crash REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6683?vs=16661&id=16755 BRANCH keyboard-leave-surface-destroy REVISION DETAIL https://phabricator.kde.org/D6683 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/keyboard_interface.cpp src/server/resource.cpp src/server/resource.h To: graesslin, #frameworks, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6683: [server] Send keyboard leave when client destroys the focused surface
graesslin planned changes to this revision. graesslin added a comment. Causes crash in KWayaland when closing a window. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6683 To: graesslin, #frameworks, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6683: [server] Send keyboard leave when client destroys the focused surface
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930. When Qt closes a window due to a key press event it starts to repeat the event as KWayland does not send a keyboard leave event. Weston on the other hand does send out the keyboard leave. In my opinion it doesn't make much sense to send out the keyboard leave in this situation and in my opinion that is a client bug, but if it makes clients happy we can send them the keyboard leave. Similar this should be done for pointer, touch, etc. BUG: 382280 TEST PLAN Run the example added to the Qt bug and it worked fine REPOSITORY R127 KWayland BRANCH keyboard-leave-surface-destroy REVISION DETAIL https://phabricator.kde.org/D6683 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/keyboard_interface.cpp src/server/resource.cpp src/server/resource.h To: graesslin, #frameworks, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
