D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter 
winterz closed this revision.
winterz added a comment.


  see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter 
winterz added a comment.


  In https://phabricator.kde.org/D6762#126463, @nalvarez wrote:
  
  > Looks reasonable – although I wonder why on earth you're building KDE stuff 
on Cygwin...
  
  
  fun.  as an experiment. i'm curious.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Kevin Funk 
kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Nicolás Alvarez 
nalvarez added a comment.


  Looks reasonable – although I wonder why on earth you're building KDE stuff 
on Cygwin...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows
Cc: nalvarez, #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Aleix Pol Gonzalez 
apol added a reviewer: Windows.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system, #windows
Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Allen Winter 
winterz added reviewers: skelly, Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

To: winterz, skelly, #build_system
Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Allen Winter 
winterz created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to 
'ld'
  else you get 
/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/../../../../x86_64-pc-cygwin/bin/ld: 
unrecognized option '--enable-new-dtags'

TEST PLAN
  see if I can build something on cygwin now

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6762

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: winterz
Cc: #frameworks, #build_system