D6800: Add template for a simple kpart-based application
This revision was automatically updated to reflect the committed changes.
Closed by commit R306:089284db0c0d: Add template for a simple kpart-based
application (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6800?vs=16946=17264#toc
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6800?vs=16946=17264
REVISION DETAIL
https://phabricator.kde.org/D6800
AFFECTED FILES
CMakeLists.txt
ExtraDesktop.sh
templates/CMakeLists.txt
templates/kpartsapp/CMakeLists.txt
templates/kpartsapp/README
templates/kpartsapp/icons/16-apps-%{APPNAMELC}.png
templates/kpartsapp/icons/32-apps-%{APPNAMELC}.png
templates/kpartsapp/icons/48-apps-%{APPNAMELC}.png
templates/kpartsapp/icons/CMakeLists.txt
templates/kpartsapp/kpartsapp.kdevtemplate
templates/kpartsapp/kpartsapp.png
templates/kpartsapp/src/CMakeLists.txt
templates/kpartsapp/src/part/%{APPNAMELC}part.cpp
templates/kpartsapp/src/part/%{APPNAMELC}part.desktop
templates/kpartsapp/src/part/%{APPNAMELC}part.h
templates/kpartsapp/src/part/%{APPNAMELC}partui.rc
templates/kpartsapp/src/part/CMakeLists.txt
templates/kpartsapp/src/part/Messages.sh
templates/kpartsapp/src/shell/%{APPNAMELC}.desktop
templates/kpartsapp/src/shell/%{APPNAMELC}shell.cpp
templates/kpartsapp/src/shell/%{APPNAMELC}shell.h
templates/kpartsapp/src/shell/%{APPNAMELC}ui.rc
templates/kpartsapp/src/shell/CMakeLists.txt
templates/kpartsapp/src/shell/Messages.sh
templates/kpartsapp/src/shell/main.cpp
To: kossebau, #frameworks, dfaure
Cc: lueck, ltoscano, aacid
D6800: Add template for a simple kpart-based application
kossebau added a comment. So with the Messages.sh sorted out (thanks @aacid for raising and @lueck for pointing out where it is already handled), if there are no objections, would add on Tuesday, 27th. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To: kossebau, #frameworks, dfaure Cc: lueck, ltoscano, aacid
D6800: Add template for a simple kpart-based application
aacid added a comment. Ok, so i guess that would apply to kparts too. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To: kossebau, #frameworks, dfaure Cc: lueck, ltoscano, aacid
D6800: Add template for a simple kpart-based application
lueck added a comment.
In https://phabricator.kde.org/D6800#128307, @kossebau wrote:
>
> I cannot see though any catalogs which would match the template-string
catalog names, so seems there is some magic already to prevent that?
l10n-kf5/scripts/extract-messages.sh:
# skip Messages.sh files of KDevelop's app templates
grep '{APPNAMELC}[^ ]*.pot' $subdir/Messages.sh 1>/dev/null && continue
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6800
To: kossebau, #frameworks, dfaure
Cc: lueck, ltoscano, aacid
D6800: Add template for a simple kpart-based application
kossebau added a subscriber: ltoscano. kossebau added a comment. In https://phabricator.kde.org/D6800#128256, @aacid wrote: > At least there is a problem l10n wise in which there is a Messages.sh so i guess it will be run and create a "fake" .pot file (and something similar for the .desktop file) > > Though probably this is already happening? Good question, had not thought about before. Indeed the existing template elsewhere also have pure Messages.sh in the tree, e.g. https://cgit.kde.org/kapptemplate.git/tree/src/templates/C++/kde-frameworks5 https://cgit.kde.org/kapptemplate.git/tree/src/templates/C++/kpartapp/src https://cgit.kde.org/kapptemplate.git/tree/src/templates/C++/akonadiresource as well as https://cgit.kde.org/plasma-framework.git/tree/templates/cpp-plasmoid https://cgit.kde.org/plasma-framework.git/tree/templates/plasma-wallpaper Looking at https://websvn.kde.org/trunk/l10n-kf5/templates/messages/kdesdk/ https://websvn.kde.org/trunk/l10n-kf5/templates/messages/frameworks/ I cannot see though any catalogs which would match the template-string catalog names, so seems there is some magic already to prevent that? @ltoscano can you raise the curtain on this matter? :) REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To: kossebau, #frameworks, dfaure Cc: ltoscano, aacid
D6800: Add template for a simple kpart-based application
aacid added a comment. At least there is a problem l10n wise in which there is a Messages.sh so i guess it will be run and create a "fake" .pot file (and something similar for the .desktop file) Though probably this is already happening? Any idea on how we would make that not happen? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To: kossebau, #frameworks, dfaure Cc: aacid
D6800: Add template for a simple kpart-based application
kossebau added a comment. Generated template: https://share.kde.org/index.php/s/cSeyBNVGvPTPAiO Follows the templates for krunner and plasma, which also are placed in the frameworks sources. Plan is to move the other templates from kapptemplate to the respective sources as well, and at the end of the day turn kapptemplate into a framework lib (and some util apps), which then allows kdevelop, kate & co. to share the from-template-generation code. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To: kossebau, #frameworks, dfaure
D6800: Add template for a simple kpart-based application
kossebau created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Inspired by kpartapp template from kapptemplates.
Keeping the template with the sources they are based on
helps both discovery and also maintenance.
REPOSITORY
R306 KParts
BRANCH
addtemplate
REVISION DETAIL
https://phabricator.kde.org/D6800
AFFECTED FILES
CMakeLists.txt
ExtraDesktop.sh
templates/CMakeLists.txt
templates/kpartapp/CMakeLists.txt
templates/kpartapp/README
templates/kpartapp/icons/16-apps-%{APPNAMELC}.png
templates/kpartapp/icons/32-apps-%{APPNAMELC}.png
templates/kpartapp/icons/48-apps-%{APPNAMELC}.png
templates/kpartapp/icons/CMakeLists.txt
templates/kpartapp/kpartapp.kdevtemplate
templates/kpartapp/kpartapp.png
templates/kpartapp/src/CMakeLists.txt
templates/kpartapp/src/part/%{APPNAMELC}part.cpp
templates/kpartapp/src/part/%{APPNAMELC}part.desktop
templates/kpartapp/src/part/%{APPNAMELC}part.h
templates/kpartapp/src/part/%{APPNAMELC}partui.rc
templates/kpartapp/src/part/CMakeLists.txt
templates/kpartapp/src/part/Messages.sh
templates/kpartapp/src/shell/%{APPNAMELC}.desktop
templates/kpartapp/src/shell/%{APPNAMELC}shell.cpp
templates/kpartapp/src/shell/%{APPNAMELC}shell.h
templates/kpartapp/src/shell/%{APPNAMELC}ui.rc
templates/kpartapp/src/shell/CMakeLists.txt
templates/kpartapp/src/shell/Messages.sh
templates/kpartapp/src/shell/main.cpp
To: kossebau, #frameworks, dfaure
