D6899: support X-KDE-OnlyShowOnQtPlatforms
This revision was automatically updated to reflect the committed changes. Closed by commit R297:937ade5d7357: support X-KDE-OnlyShowOnQtPlatforms (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6899?vs=17177=18132#toc REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17177=18132 REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h To: mart, #frameworks, #plasma, davidedmundson Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma, davidedmundson Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added a comment. ping? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
dfaure added a comment. Ah, this key is already used, for applications? I wasn't aware, if that's the case. Hmm, then maybe better keep the same key indeed. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added a comment. In https://phabricator.kde.org/D6899#133625, @dfaure wrote: > "Show" is a bit of a historical name here, this isn't about showing apps in a menu... > > X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no? > > Looks good otherwise. that would be a new key, would you prefer that version? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
dfaure added a comment. "Show" is a bit of a historical name here, this isn't about showing apps in a menu... X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no? Looks good otherwise. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart updated this revision to Diff 17176. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. readstringlist REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17175=17176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h src/kdedmodule.desktop To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added a comment. ah, yeah, that's a leftover, should go REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart updated this revision to Diff 17177. mart added a comment. less blanks REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17176=17177 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart marked 2 inline comments as done. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
broulik added a comment. Also, your property is `X-KDE-PluginInfo-OnlySupportedPlatform` but you check for `X-KDE-OnlyShowOnQtPlatforms` REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
broulik added inline comments.
INLINE COMMENTS
> kded.cpp:328
> +{
> +const QStringList supportedPlatforms =
> module.rawData().value(QStringLiteral("X-KDE-OnlyShowOnQtPlatforms")).toVariant().toString().split(QStringLiteral(";"),
> QString::SkipEmptyParts);
> +
KPluginMetaData::readStringList(module.rawData(),
QStringLiteral("X-KDE-OnlyShowOnQtPlatforms"));
> kded.cpp:330
> +
> +return supportedPlatforms.count() == 0 ||
> supportedPlatforms.contains(qApp->platformName());
> +}
`isEmpty()`
> kded.h:90
> + */
> +bool platformSupportsModule(const KPluginMetaData ) const;
> +//@}
static?
> kdedmodule.desktop:111
> +[PropertyDef::X-KDE-PluginInfo-OnlySupportedPlatform]
> +Type=QString
QStringList
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart, #frameworks, #plasma
Cc: broulik, #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added reviewers: Frameworks, Plasma. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY some kded modules can only run in one platform, especially only xcb or only wayland. this makes kded support the X-KDE-OnlyShowOnQtPlatforms entry in the desktop file TEST PLAN touchpad and keyboard kdeds not loaded in wayland REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h src/kdedmodule.desktop To: mart Cc: #frameworks
