D6906: Create a "." entry even on empty dirs
albertvaka added a comment. Mmmm it could be because kio_desktop is a ForwardingSlave, so the entry is added first by its forwardee (kio_file I think) and then again by kio_desktop itself? I'm not sure if what I'm saying even makes sense because I don't really know how KIO works. Will investigate a bit... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio Cc: aacid, dfaure
D6906: Create a "." entry even on empty dirs
albertvaka added a comment. Reverted the patch. Couldn't figure out what is wrong with it though... I don't think that "." is being emitted multiple times because of this patch. It looks more like if kio_desktop was causing listEntries to be called twice. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio Cc: aacid, dfaure
D6906: Create a "." entry even on empty dirs
dfaure added a comment. Difficult to test in kio itself, but for sure testable in the autotest for kio_desktop (plasma-workspace/kioslave/desktop/tests) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio Cc: aacid, dfaure
D6906: Create a "." entry even on empty dirs
dfaure added a comment.
This commit breaks plasmashell startup for me, with a non-empty desktop:/
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980)
KIO::ListJob(0x26a9ae0) new entries for QUrl("desktop:/")
2017-07-28T10:51:54 plasmashell(5605)/default
KCoreDirListerCache::slotEntries: ".directory"
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirListerCache::slotEntries: Adding item: QUrl("desktop:/.directory")
2017-07-28T10:51:54 plasmashell(5605)/default
KCoreDirListerCache::slotEntries: ".."
2017-07-28T10:51:54 plasmashell(5605)/default
KCoreDirListerCache::slotEntries: "."
2017-07-28T10:51:54 plasmashell(5605)/default
KCoreDirListerCache::slotEntries: "Home.desktop"
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirListerCache::slotEntries: Adding item: QUrl("desktop:/Home.desktop")
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirLister::Private::addNewItem: in QUrl("desktop:/") item:
QUrl("desktop:/Home.desktop")
2017-07-28T10:51:54 plasmashell(5605)/default
KCoreDirListerCache::slotEntries: "trash.desktop"
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirListerCache::slotEntries: Adding item: QUrl("desktop:/trash.desktop")
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirLister::Private::addNewItem: in QUrl("desktop:/") item:
QUrl("desktop:/trash.desktop")
2017-07-28T10:51:54 plasmashell(5605)/default
KCoreDirListerCache::slotEntries: done
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980)
KIO::ListJob(0x26a9ae0) new entries for QUrl("desktop:/")
2017-07-28T10:51:54 plasmashell(5605)/default unknown: ASSERT:
"dir->rootItem.isNull()" in file
/d/kde/src/5/frameworks/kio/src/core/kcoredirlister.cpp, line 1202
At first sight it looks like "." is emitted multiple times.
Please revert and fix it better ;)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
To: albertvaka, #frameworks, elvisangelaccio
Cc: dfaure
D6906: Create a "." entry even on empty dirs
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0ac78aa3fba4: Emit a "." UDSEntry when not present, even on empty directories. (authored by albertvaka). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6906?vs=17194=17207 REVISION DETAIL https://phabricator.kde.org/D6906 AFFECTED FILES src/core/slavebase.cpp To: albertvaka, #frameworks, elvisangelaccio
D6906: Create a "." entry even on empty dirs
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Tested with mtp and it works, thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio
D6906: Create a "." entry even on empty dirs
albertvaka added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio
D6906: Create a "." entry even on empty dirs
albertvaka edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks
D6906: Create a "." entry even on empty dirs
albertvaka created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Fixes bug 382046 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 AFFECTED FILES src/core/slavebase.cpp To: albertvaka, #frameworks
