D6936: ECMGeneratePriFile - mac os x framework builds of Qt

2017-07-26 Thread Allen Winter 
winterz abandoned this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6936

To: winterz, dfaure
Cc: #frameworks, #build_system

D6936: ECMGeneratePriFile - mac os x framework builds of Qt

2017-07-26 Thread David Faure 
dfaure added a comment.


  This would make a large number of other headers accessible on other Unixes.
  
  So this additional include should be added only on Mac OS.
  
  I'm also a bit confused by the description. You say "QT/include" but this is 
rather about the includes for the framework, no?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6936

To: winterz, dfaure
Cc: #frameworks, #build_system

D6936: ECMGeneratePriFile - mac os x framework builds of Qt

2017-07-26 Thread Allen Winter 
winterz created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  on mac os x framework builds of Qt, QT/include is not added to the list of 
include path,. this patch looks up one level so those includes can be found

TEST PLAN
  used the generated pri file on Mac

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6936

AFFECTED FILES
  modules/ECMGeneratePriFile.cmake

To: winterz, dfaure
Cc: #frameworks, #build_system