D6941: fix plasmashell unsetting QSG_RENDER_LOOP

2017-07-27 Thread Martin Koller 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:886dd7aaa33d: fix plasmashell unsetting QSG_RENDER_LOOP 
(authored by mkoller).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6941?vs=17258&id=17276

REVISION DETAIL
  https://phabricator.kde.org/D6941

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: mkoller, davidedmundson
Cc: #frameworks

D6941: fix plasmashell unsetting QSG_RENDER_LOOP

2017-07-26 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D6941

To: mkoller, davidedmundson
Cc: #frameworks

D6941: fix plasmashell unsetting QSG_RENDER_LOOP

2017-07-26 Thread Martin Koller 
mkoller created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  being hit by the problem of plasmashell using way too much CPU even when 
doing "nothing", I found
  the description of the QSG_RENDER_LOOP env variable to be settable to basic, 
which solves the problem.
  However, even though I set the var in ~/.config/plasma-workspace/env/KDE5.sh 
plasmashell (and only this process)
  always ends up having the var set to an EMPTY string (I check this via 
/proc/PIC/environ).
  
  I don't know from where RendererSettings is initialized, but I assume that 
the QString inside it is
  not null but empty, so isNull() == false but isEmpty() == true
  
  With this patch, QSG_RENDER_LOOP=basic is now correct in plasmashell's env 
after a login.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D6941

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: mkoller, davidedmundson
Cc: #frameworks