D7085: Fix issue where notifications will show as 1 pixel line
davidedmundson abandoned this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7085 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7085: Fix issue where notifications will show as 1 pixel line
mart added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7085 To: davidedmundson, #plasma Cc: #frameworks
D7085: Fix issue where notifications will show as 1 pixel line
davidedmundson added a comment. Apparently doesn't fix the bug that brought me here. To me the code still makes sense, but equally I don't want to touch this clearly cursed class any more than possible. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7085 To: davidedmundson Cc: #frameworks
D7085: Fix issue where notifications will show as 1 pixel line
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Dialog::setVisible doesn't do anything if the QML hasn't finished setting initial properties (componentCompleted) componentComplete() method used to duplicate the code that was in Dialog::setVisible(). Dialog::setVisible was changed in https://phabricator.kde.org/R242:eab4aa9909a62cce9b32555ed28d142569fb467f. componentComplete was not. Rather than copying the code, we can call the method directly. BUG: 382340 TEST PLAN Popups are exactly the same on my system, but as I couldn't reliably reproduce the original bug that doesn't really prove anything useful REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7085 AFFECTED FILES src/plasmaquick/dialog.cpp To: davidedmundson Cc: #frameworks
