D7136: Don't use find_file for finding files in our own source dir
This revision was automatically updated to reflect the committed changes. Closed by commit R311:a14de9351608: Don't use find_file for finding files in our own source dir (authored by vkrause). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7136?vs=17843&id=17848 REVISION DETAIL https://phabricator.kde.org/D7136 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: vkrause, #frameworks, kfunk Cc: apol, kfunk
D7136: Don't use find_file for finding files in our own source dir
kfunk accepted this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: apol, kfunk
D7136: Don't use find_file for finding files in our own source dir
vkrause updated this revision to Diff 17843. vkrause added a comment. Replace now pointless relative path REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7136?vs=17728&id=17843 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: vkrause, #frameworks, kfunk Cc: apol, kfunk
D7136: Don't use find_file for finding files in our own source dir
apol added inline comments. INLINE COMMENTS > CMakeLists.txt:81 > > -find_file(kwallet_xml org.kde.KWallet.xml HINTS > ${CMAKE_CURRENT_SOURCE_DIR}/../../api/KWallet) > +set(kwallet_xml > ${CMAKE_CURRENT_SOURCE_DIR}/../../api/KWallet/org.kde.KWallet.xml) > How about `${CMAKE_SOURCE_DIR}/src/api/KWallet/org.kde.KWallet.xml`? Making it relative isn't doing much anyway. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: apol, kfunk
D7136: Don't use find_file for finding files in our own source dir
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I don't see why `find_file` would be needed here, yep. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: kfunk
D7136: Don't use find_file for finding files in our own source dir
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY It's not necessary, and it breaks when cross-compiling, as find_file changes its behavior then. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: vkrause, #frameworks