D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

2017-08-10 Thread David Faure
dfaure created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This allows to bundle servicetype desktop files into libraries
  to make it possible to run executables without the desktop file
  installed.

TEST PLAN
  kpackage unittests, after adding kpackage-generic.desktop
  to a qrc file for kpackagetool.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7236

AFFECTED FILES
  src/lib/plugin/desktopfileparser.cpp

To: dfaure, mart
Cc: #frameworks


D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

2017-08-25 Thread David Faure
dfaure added reviewers: arichardson, davidedmundson.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7236

To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks


D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

2017-08-25 Thread David Faure
dfaure added a comment.


  ping?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7236

To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks


D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

2017-08-25 Thread Alex Richardson
arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.


  Looks good to me. 
  Test would be great but the patch is pretty trivial so not really needed.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7236

To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks


D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

2017-08-25 Thread David Faure
dfaure added a comment.


  It will be tested at every "make test" in kio and kpackage ;-)

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7236

To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks


D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

2017-08-25 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7236

To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks